bonitasoft / bonita-documentation-site

The sources of the Bonita Documentation site
https://documentation.bonitasoft.com/
GNU General Public License v2.0
9 stars 5 forks source link

fix: Don't publish comments when no files is update #674

Closed benjaminParisel closed 4 months ago

benjaminParisel commented 4 months ago

Skip the Comments step when no file updates are detected.

Closes #534

github-actions[bot] commented 4 months ago

:recycle: PR Preview 7355a4e5610ad25e7ad53a56f2711773e526ea18 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

github-actions[bot] commented 4 months ago

:recycle: PR Preview 7355a4e5610ad25e7ad53a56f2711773e526ea18 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

benjaminParisel commented 4 months ago

I cherry-picked the commit from the #673 Pull request to test the preview workflow. In #673, we see a useless comment with some undefined/undefined links.

image

With the fix in this PR, this link is not adding for this PR.

tbouffard commented 4 months ago

Put in draft until we remove the cherry-pick commit to validate the fix. Once merged, this will be tested in #673

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

tbouffard commented 4 months ago

I am merging this PR and validate the change in the master branch by updating https://github.com/bonitasoft/bonita-labs-doc/pull/152 ✔️ Tests OK: https://github.com/bonitasoft/bonita-labs-doc/pull/152#issuecomment-1972995194