ci: bump actions used in composite actions

tbouffard commented 7 months ago

Use the latest available and compatible versions

actions/upload-artifact v3 to v4
tj-actions/changed-files v40 to v42

This also ensures that the actions run with node 20 (remove warning about running actions with the deprecated Node 16 version).

In addition

always upload artifacts to be able to test locally by downloading the content of the preview.
postfix the name of the artifacts with the job id. This ensures to have unique name if the upload is done several times (name uniqueness is required by the new version of the upload-artifact action). This is needed for the doc-site PR as 2 previews are built (test and production contents)

tbouffard commented 7 months ago

❌ artifact upload fails in the context of the doc-site. We publish 2 sites (one with test data and another one with real content). We upload the artifacts twice with the same name wich is no longer possible with the new version of the upload actions

See https://github.com/bonitasoft/bonita-documentation-site/actions/runs/8016859893/job/21899620556?pr=676.

Run ./.github/actions/upload-pr-built-site-artifact
Run actions/upload-artifact@v4
  with:
    name: site-preview-pr-676-38968c04ce5d8f30ab2dc5ae0e4842f762344dfe
    path: build/site
    if-no-files-found: warn
    compression-level: 6
    overwrite: false
  env:
    npm_config_cache: /home/runner/.npm
With the provided path, there will be 1186 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run