search

bonitasoft / bonita-documentation-theme

Dedicated Antora UI Bundle used to produce the Bonita Documentation
https://bonitasoft.github.io/bonita-documentation-theme/
Mozilla Public License 2.0
4 stars 6 forks source link

fix: display the images in footer and "edit this page" #150

Closed tbouffard closed 1 year ago

tbouffard commented 1 year ago

Use the {{{uiRootPath}}} template variable instead of hard coded path. The hard coded path works with the theme preview but not when used to build the site.

Closes #149

For reviewers

This change requires manual testing. Build a part of the site using the new bundle. See https://github.com/bonitasoft/bonita-documentation-site#using-local-ui-bundle For instance, with something like ./build-preview-dev.bash --local-ui-bundle --use-test-sources

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

github-actions[bot] commented 1 year ago

:recycle: PR Preview f244c0cc3608e8732c95f2dad1305100151c2444 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview