search

bonitasoft / bonita-documentation-theme

Dedicated Antora UI Bundle used to produce the Bonita Documentation
https://bonitasoft.github.io/bonita-documentation-theme/
Mozilla Public License 2.0
4 stars 6 forks source link

fix: Make nav bar over message block #163

Closed jeromecambon closed 1 year ago

jeromecambon commented 1 year ago

Covers https://github.com/bonitasoft/bonita-documentation-theme/issues/121

github-actions[bot] commented 1 year ago

:recycle: PR Preview 84e8609d1e2b917de4fa474f2f41c47670cfdd36 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

jeromecambon commented 1 year ago

✔️ the toolbar is now on top ❌ when clicking on the arrow, the toolbar doesn't hide anymore

Here is how it behaves in the current master branch (the file name of the videos provided here are wrong)

02_PR_current.mp4

And in the PR preview

01_before_current_master_branch.mp4

Good catch. The problem is because the message block is part of the toolbar. This makes difficult to separate the behavior of the message block from the "real" toolbar. A solution I investigated is to have a dedicated "block" for the message block, between the header and the toolbar. But as stated in the issue this change a lot the whole layout. Since the issue is only for mobile (or very small window) and very specific versions, I suggest we keep the current behavior (i.e. without this fix) for now. Unless somebody wants to have a look, in case I missed an obvious solution...

tbouffard commented 1 year ago

Since the issue is only for mobile (or very small window) and very specific versions, I suggest we keep the current behavior (i.e. without this fix) for now.

The PR improves things so we could merge as it is provided here. If so, I will open an issue about the arrow not working anymore. We cannot silent problems like this one just because it is hard to fix.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jeromecambon commented 1 year ago

Since the issue is only for mobile (or very small window) and very specific versions, I suggest we keep the current behavior (i.e. without this fix) for now.

The PR improves things so we could merge as it is provided here. If so, I will open an issue about the arrow not working anymore. We cannot silent problems like this one just because it is hard to fix.

I don't have a strong opinion on this. The fix improves things on one side but may also have unwanted side effects. But let's push it.

tbouffard commented 1 year ago

See issue #167 about the back button not working anymore