bonitasoft / bonita-documentation-theme

Dedicated Antora UI Bundle used to produce the Bonita Documentation
https://bonitasoft.github.io/bonita-documentation-theme/
Mozilla Public License 2.0
4 stars 6 forks source link

fix: Remove extra margin-top in the TOC #179

Closed jeromecambon closed 11 months ago

jeromecambon commented 1 year ago

The 'top' css property was not needed.

Closes https://github.com/bonitasoft/bonita-documentation-theme/issues/123

github-actions[bot] commented 1 year ago

🎊 PR Preview 2c2b77b65375fc97d1b1e573f07e01831f0de757 has been successfully built and deployed to https://bonitasoft-bonita-documentation-theme-build_preview-pr-179.surge.sh

:clock1: Build time: 0.011s

🤖 By surge-preview

jeromecambon commented 1 year ago

With 2f32377

Before:

https://user-images.githubusercontent.com/17833345/219708569-9e7dd2ce-6232-4d49-aee7-e1bee58cc010.mov

After:

https://user-images.githubusercontent.com/17833345/219708696-92829e66-729f-4d96-9e48-c34fe7dbb9ce.mov

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jeromecambon commented 1 year ago

I agree it would be better to do it at generation time. I'll try to do it...

tbouffard commented 1 year ago

I agree it would be better to do it at generation time. I'll try to do it...

OK, I'll try something in a dedicated PR later. This will allow you to work on other topics and we can compare the two approaches.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tbouffard commented 11 months ago

Closing. It will be rework later.