Closed McGravel closed 2 years ago
the PurePosixPath does change the model's backslash to a forward one, so at least it matches the UI more...
However, the error still occurs; debugging seems to indicate that Popen
makes the path with backslashes, even though the args
variable appears to use forward ones as input?
More info on what is happening on Windows: https://docs.python.org/3/library/subprocess.html#converting-argument-sequence
This issue isn't what I was expecting, so i'll close this for now and consider making an Issue instead.
Thanks Xbmann for accidentally coming across this error!
This should fix the UnicodeDecode exception if the user had
\x
in their model's path.I don't know if PurePosixPath should be used elsewhere to fix any other backslashes, so I suppose this could be considered a hotfix of sorts.
I'm presuming this is only an issue on Windows since it likes to use backslashes in paths, unsure if functionality is affected on other platforms by this change.
If this fixes the error, then it may be worth considering what other paths should be changed to
PurePosixPath
Example error given:![image](https://user-images.githubusercontent.com/87149601/126368976-02420b06-bbdb-4ccd-a3c4-924b167d62fa.png)