bonjorno7 / SourceOps

A more convenient alternative to Blender Source Tools.
GNU General Public License v3.0
138 stars 14 forks source link

Calculate texture scale and offset for brushes. #80

Closed Nieblist closed 2 years ago

Nieblist commented 2 years ago
Nieblist commented 2 years ago

Hi reviewers. Please note that the Allow Skewed Textures option is not working for all cases right now. It seems to be flipping some textures or otherwise having some issues.

I decided to keep it because it can be useful (I'm using it for my map), but if you prefer I can remove it for now and create another PR in case I find a way to fix it.

Nieblist commented 2 years ago

Hi @bonjorno7, please let me know if there is any reason not to merge this. It has been pretty useful for my map. Do you prefer me to remove the "Allow Skewed Textures" option and keep only orthogonal mappings?

(This is for issue https://github.com/bonjorno7/SourceOps/issues/79)

bonjorno7 commented 2 years ago

Hi @Nieblist sorry for the wait, I've been busy lazy. I'll post a review in a bit.

bonjorno7 commented 2 years ago

Oh and I'm fine with keeping the skewed textures option, even if it isn't perfect (the rest of the addon isn't either).

Nieblist commented 2 years ago

Cool! I'll keep it as it is for now then and come back at it if I have time. Please let me know if you find anything else.

Nieblist commented 2 years ago

Hi @bonjorno7! Sorry to bug you, I'm just pinging you again in case we can merge this :)

bonjorno7 commented 2 years ago

Oh sorry I forgot, will take a look and maybe merge tomorrow.

Nieblist commented 2 years ago

Nice, ok!

bonjorno7 commented 2 years ago

Sorry for being so unavailable, I should be better. Everything looks good now, and seems to work fine from my testing, so I'll merge. Thank you for your contribution!

Nieblist commented 1 year ago

Happy to help, thank you for the plugin!