Wrong visibility values in resized videos

bonn-activity-maps / bam_annotation_tool

Bonn Activity Maps annotation tool

4 stars 1 forks source link

Wrong visibility values in resized videos #395

Closed dari1495 closed 3 years ago

dari1495 commented 3 years ago

sequence 001022 person 7 frame 40 left shoulder? why don't I have the visibility button

dari1495 commented 3 years ago

Apparently the problem is that at some point, the coordinates (all) were multiplied by 2 in the resize videos, multiplying the visibility coordinates as well.

dari1495 commented 3 years ago

person 16 frame 129 and 133

dari1495 commented 3 years ago

track_id 2 frame 28 video 001962 uid 1001962002802

dari1495 commented 3 years ago

@Belberus I suspect the multiplying visibility by 2 is still happening

dari1495 commented 3 years ago

I wrote a script to find videos that contain incorrect values and found the following:

Several videos have visibility as 2 (and it keeps adding more)
Some videos have None as visibility (this somehow still works in the frontend, but should be fixed)
Every non-annotated person has "keypoints" as an empty array. This obviously confuses the frontend. This could be fixed either way on the frontend or backend, by substituting the empty lists with [[0, 0, 0]...] or by making the frontend understand how to treat an empty array.
There is at least one empty keypoint with [] which is obviously wrong and should be fixed

dari1495 commented 3 years ago

It is possible that when deleting a point, the visibility is still sent to the backend and saved as [vis, null, null]. Please also check this @Belberus

dari1495 commented 3 years ago

Should be fixed. Closing for now, but may reopen in the future if it happens again

dari1495 commented 3 years ago

The bug appears to be fixed so far.

For the time being, I should focus on writing a script to recover the broken person objects. Given the nature of the bug (Multiplying by 2 unnecessarily), it should be as easy as dividing by 2, but it might not be the case for all of the poses.

[x] Investigate if all of the broken poses are indeed multiplied by 2
[x] Modify fix_person script to fix those poses by dividing or whatever is necessary