bonnkleiford / MSPLib-Library

MSPLib Problems Library initial repository for synthetic problems
6 stars 1 forks source link

Add a JSON schema #2

Open odow opened 1 year ago

odow commented 1 year ago

We should add a JSON schema that can be used to validate lattice and problem files.

As examples, see:

JSON-schema is defined by:

There is a Python library for validating:

bonnkleiford commented 12 months ago

I think this is really interesting and helpful. I will definitely add this. Thanks for the suggestion!

bonnkleiford commented 11 months ago

Hi Oscar , How are you? I am coming to the last stages of the benchmarking and I have two new additional real-world problems that the MSPFormat reader cannot read successfully.

Problem_16.tar.gz Problem_17.tar.gz

I am also slowly addressing each issues on the MSPLib GitHub repo (specifically this JSON Schema and the MetaData). Thanks again for the recommendations.

odow commented 11 months ago

Do you have a log of the errors?

(p.s. Are you coming to Paris with Nils?)

bonnkleiford commented 11 months ago

For Problem #16:

Screenshot 2023-10-02 at 16 28 25

For Problem #17:

Screenshot 2023-10-02 at 16 28 35

Vincent Leclere invited me to give a talk but I could not as I have my defence on the 13th October. It would be nice though. Nils is going only for his talk, if I am not mistaken.

If you have time, Luxembourg is a 2-hour train ride and I I can show you around!

odow commented 11 months ago

Hmm. So these errors are because storage_5 appears as a state variable, but it does not appear in every stage. We can work-around this in the SDDP reader, but more generally, we should ask: does the vector of state variables need to be constant across the nodes in a graph?

odow commented 11 months ago

The files contain Dict{String, Any}("MIN" => 9.549789656601526) and Dict{String, Any}("MAX" => 0.0). What are these nodes?

bonnkleiford commented 11 months ago

Hmmm. I am also not sure. Let me check this up with Nils.