Open glopesdev opened 1 month ago
This should be allowed to avoid having to pass the operator instance into the method call.
Why? What makes this valuable?
Why? What makes this valuable?
Maybe nothing apart from pleasing the gods of code suggestions, they keep highlighting that "this code could be marked as static". I don't know if there would be any performance optimizations to executing static methods over instance methods, but other than that I agree there is not a compelling reason to do this, just added it in here as a thought record.
The code suggestion gods are lesser gods and their advice need not necessarily be heeded.
I'd be more inclined to offer a Bonsai Roslyn analyzer which suppresses these suggestions.
performance
The performance difference would be absolutely minuscule (to the point it'd be hard to even measure.)
It can happen in some pure implementations of reactive operators that the implementation of the combinator method does not require any local operator state. In this case the
Process
orGenerate
function could be marked asstatic
.This should be allowed to avoid having to pass the operator instance into the method call. Care must be taken when evaluating overloads.