bonsai-rx / labjack

Bonsai Library containing interfaces for measurement and automation using LabJack hardware.
MIT License
3 stars 3 forks source link

help adding Labjack to Bonsai #1

Open amchagas opened 4 years ago

amchagas commented 4 years ago

Hi! For some of the applications in the lab, we are using a "cheap" DAQ system named LabJack (LJ). More specifically their T7 model.

Since the company that produces this provides a lot of example code to run it in several different languages, I thought it could be fruitful to try and port their C# code to Bonsai. My end goal would be to them use this DAQ with other parts we have here to create a user friendly photometry system.

As a complete C#, .net, nuget noob, the attempts I made got nowhere unfortunately. I followed the documentation here but the code generated when creating a new Bonsai project is different from the one in the documentation and running the project with F5 doesn't create a node in Bonsai. Which is not the main issue, but made it a bit harder for me to understand if at least this minimal example was running properly.

As I tried to move forward anyways, I attempted to copy bits and pieces of code from the LabJack examples, but got stuck in the very first line where I wanted to add Using LabJack; (which is needed in the LJ example code) but got an error. I am under the impression things are properly set on my computer as I'm able to run the LJ example code using VS2017.

So, after all this long explanation (sorry!) I would like to ask if anyone could offer me a hand on this one! I'm also happy with pointers, links, tutorials on C#/Bonsai, other bonsai examples that are implementing simpler DAQs, etc.

thanks!

vncntprvst commented 4 years ago

Hi Andre, I share your interest in adding Labjacks to Bonsai, as I use a T4 model for some experiments. I'm not an experienced C# coder though, but if you haven't made headway in the next couple weeks, maybe we can partner up and try to do that?

glopesdev commented 4 years ago

@amchagas @vncntprvst Unfortunately I don't have any LabJack hardware with me. However, if you two are willing to spearhead the development, I'm happy to help you start an official `Bonsai.LabJack´ repository, provide a code template, and do code-reviews/suggestions for organizing the code in a way that makes everything fit well together, and we could all three collaborate on that.

How does that sound?

amchagas commented 4 years ago

Hi @glopesdev @vncntprvst Getting this off the ground collaboratively would be great!

best, Andre

vncntprvst commented 4 years ago

@glopesdev @amchagas That sounds great. As mentioned above, I'm won't be able to work much on this for the next couple weeks, but after that I'm happy to contribute.

amchagas commented 4 years ago

hi folks, just following up on this one, how do we want to start? @glopesdev could you provide code templates? or point us in their direction please? And create a labjack repo if you feel this would be good, otherwise we could also wait to see if we make progress on it?

glopesdev commented 4 years ago

@amchagas sure, let's move to this repository then: https://github.com/bonsai-rx/labjack

I would suggest we coordinate and plan there using issues, but maybe we could schedule a few quick discussions over Discord? I've created a #labjack channel. Here's a quick 1-day invite link: https://discord.gg/hdBVJm

P.S.: I'm transferring the issue over there too