bonukai / MediaTracker

Self hosted media tracker for movies, tv shows, video games, books and audiobooks
MIT License
571 stars 23 forks source link

Item External Link in the DB? #502

Open jonkristian opened 1 year ago

jonkristian commented 1 year ago

I just created a PR for Discord webhook notification, but it would be nice to be able to include an external link so that it will embed media. I see that you generate external links in Details.tsx , would you consider adding a new db field with external_link and included that in Notifications.sendNotifications() ? I think it would benefit other notification platforms as well.

bonukai commented 1 year ago

@jonkristian Thank you for you contribution, it is now available in stable release.

There is no need for storing external links in the database, as all information needed for them are already in there.

I wouldn't want the notifications to be bloated, I would rather keep them compact, as each release has it's own notification, so for someone who watches a lot of tv shows, there will be a lot of notifications, but I am open for discussion. There is also the issue with each notification platform having different display options, and features.

Could you please create a notification you would like, on Discord, and share the screenshot here?

jonkristian commented 1 year ago

You are welcome, and thank you for this awesome solution!

I totally agree with you when it comes to tv shows, so if implemented it should probably have an option for each media type.

Also discord embedded media is one thing, but something else I've thought about: For TV shows this could be too much, but say you added a movie 1 year ago and get a release notification, it would be nice to have the link in the notification if you need a refresher to quickly check it out.

I also agree with you about keeping it neat and tidy, could probably avoid new db field and create a function to pass media item id's to it and get link in response.

Not sure how it should look though, maybe just plain text too like:

zelda

and then suffixed with | IGDB

bonukai commented 1 year ago

I have updated notifications to include link in the title, for services that support it: gotify, Discord, Pushover and Pushsafer, in #508