search

boocs / ue4-intellisense-fixes

Automatically fixes VSCode/Unreal Engine Intellisense Config bugs on startup
MIT License
162 stars 9 forks source link

Add ability to cancel remaining missing files #5

Closed mikeseese closed 2 years ago

mikeseese commented 2 years ago

Hi!

Thanks for working on this extension!

Unfortunately, during using it, I had a whopping 619 missing paths, and clicking Cancel on each of them would just take forever. This PR adds the option for the user to cancel the remaining missing paths with one button press (by simply breaking the loop).

Even if there is a configuration problem with my project, without this option users are basically forced to force end the vscode task to get away from this "endless" prompt loop.

Let me know if you want any changes!

boocs commented 2 years ago

Nice fix!

I'm not sure what you mean by the trailing whitespace. It's hard to read on the diff. If the trailing whitespace is nothing big I can fix it after the pull.

I'm also not sure how to merge this. Do I merge this from github then do a pull, test it, and then update the install file?

I'm relatively new to all this.

mikeseese commented 2 years ago

I'm not sure what you mean by the trailing whitespace. It's hard to read on the diff. If the trailing whitespace is nothing big I can fix it after the pull.

Trailing whitespace is spaces/tabs at the end of the line. It really makes no difference, and in my opinion it's cleaner without them (they're usually added accidentally during the coding process/habit). You can safely ignore the fact that a handful of them were removed in this PR with no meaningful change.

I'm also not sure how to merge this. Do I merge this from github then do a pull, test it, and then update the install file?

The merge happens on GitHub; there should be a Merge Pull Request button near the bottom of the page. You can also read more instructions on how to merge here: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request

Merging will either create a merge commit (the default option), squash the commits, or just rebase the commits (a way to merge without a merge commit). The docs linked above describe those options; using the default option is perfectly fine (and it's what I use the majority of the time).

Once it's merged, you just do a pull from your computer to get the post-merge updates, do your testing, make any changes you want, and create the vsix file, and make a new release on GitHub.

There's a more complicated method that you could test the changes before merging the PR, but it's probably not worth the effort (at least in this case). I can explain that if you're interested in it