Error consolidating UK data

boogheta / coronavirus-countries

COVID-19 interactive dashboard for the whole world

https://boogheta.github.io/coronavirus-countries/

GNU Affero General Public License v3.0

55 stars 16 forks source link

Error consolidating UK data #41

Closed aramse closed 4 years ago

aramse commented 4 years ago

Running the consolidate_uk.py file is returning the following error:

$ ./bin/consolidate_uk.py > data/uk.csv
Traceback (most recent call last):
  File "./bin/consolidate_uk.py", line 55, in <module>
    print(",".join([d, b, str(countries[b]["confirmed"][i]), str(countries[b]["deceased"][i])]))
IndexError: list index out of range

boogheta commented 4 years ago

Well caught, this was due to some change in England's historical data that was improved by @TomWhite and badly handled on my side. Thanks for the report!

aramse commented 4 years ago

@boogheta I'm seeing the same error again.

$ bin/update_sources.sh 
Traceback (most recent call last):
  File "./bin/consolidate_uk.py", line 58, in <module>
    print(",".join([d, b, str(countries[b]["confirmed"][i]), str(countries[b]["deceased"][i])]))
IndexError: list index out of range

But it seems it fails this time near the very end of processing the data, and doesn't affect any data that actually gets charted.

boogheta commented 4 years ago

Yes indeed, thanks again @aramse. The data was improved again, now tests are complete and I could integrate them as well, although it looks to me like there are some weird values for England and UK total at the source, I took an arbitrary choice in the mean time and reported it here https://github.com/tomwhite/covid-19-uk-data/issues/52

aramse commented 4 years ago

@boogheta firstly want to thank you for maintaining this beautifully efficient graph for comparing COVID data across countries. It's been very helpful to me personally in keeping up more with just the numbers and less with the politics.

Also wanted to mention that I'm actually running this on Google Cloud: see this link.

This is equipped with automatic data refreshes, autoscaling, CI/CD, monitoring, and more. Let me know if you're interested in a detailed demo of how this is set up and/or you're interested in doing this for any other applications!

(Also let me know if I should make any changes with the way I'm crediting yourself/your company in the banner of this page.)

boogheta commented 4 years ago

Hi @aramse, I don't have any issue with the app being replicated slighly modified, this is open source. Although, it does have a specific open source licence (AGPL v3) which supposes to respect a few rules when you do so. Among which it minimally requires you to:

attribute properly (so a link to the médialab website won't suffice, you need to give links to the original app and its code, with the original name of the app and of the authors, meaning me from médialab and not only médialab)
redistribute the sourcecode of any public instance released, meaning the code of your fork shall be also released as opensource under that same licence on some public git repository and linked to from your platform

Thanks in advance!

aramse commented 4 years ago

Great will look to do make the needed modifications to comply here, thank you!

aramse commented 4 years ago

Updated to better comply 🙂