search

bookalope / InDesign-CEP

Adobe CEP extension for InDesign to use the Bookalope cloud services. You can download the extension from Adobe Exchange.
http://bookalope.net/
MIT License
15 stars 6 forks source link

Add Spectrum-CSS #1

Closed jenstroeger closed 5 years ago

jenstroeger commented 5 years ago

This is @nGolubeva’s contribution to spiffy up the extension’s UI, and to add Adobe’s Spectrum CSS.

nGolubeva commented 5 years ago

The file css/bookalope.css seems to contain a new reset file normalize.css. What was your reason to replace reset.css? I would probably add the normalize file separately.

Normalize.css added to file separately. CSS resets aim to remove all built-in browser styling, Normalize CSS aims to make built-in browser styling consistent across browsers. You can read for more detail https://stackoverflow.com/questions/6887336/what-is-the-difference-between-normalize-css-and-reset-css or https://pineco.de/a-brief-about-css-reset-and-normalize/

_The css/spectrum/* files are generated from the repo, right?

Yes. Components are included only those that are used in the extension.

_The js/bookalope-modules.js (i.e. UMD module) is related to Spectrum?__

Not all. The 'loadIcons' from Spectrum, but others are my scripts.

Curious: why did you choose SVGs instead of * for required fields?

So used in Spectrum.

I think we can remove the aria-hidden tags from the elements considering that we don’t use ARIA anywhere else in the HTML. I’m actually unsure about accessibility support for Adobe extensions…

Done.

Also, I noticed that all of your CSS misses a ; for the last rule before the closing }… is that intended?

This was done by the gulp-cssmin. Updated.

I’ve attached a diff (or should I commit?) for you to review: cep-dev.diff.gz

Commited.