bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 138 forks source link

Made testcases pytest compatible #339

Closed sanchitgangwar closed 10 years ago

sanchitgangwar commented 10 years ago

Fixes #323. Had to make some from bookie.bcelery import tasks statements local to method definitions. The reason, as I found out, was that importing tasks lead to execution of some global statements which prevented pytest from working.

mitechie commented 10 years ago

Thanks for this! I've landed the branch along with some lint changes and such. I ended up moving the bcelery imports back to the outer file. I didn't get any issues. If you could provide some details on why those needed to be moved I can see if I can reproduce, but for now it's working as is.

sanchitgangwar commented 10 years ago

Yes, it is working, strangely. No worries, then.