search

bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 138 forks source link

Api for stats information #398

Closed sambuddhabasu closed 10 years ago

mitechie commented 10 years ago

This branch is good, I've got a few small suggestions. It seems it's missing some work in the dashboard view to remove the work it's doing there to build the current data in the page. If we move the work to the api we're adding some code and should be able to remove some code.

mitechie commented 10 years ago

:testit:

mitechie commented 10 years ago

test this please

craigmaloney commented 10 years ago

Test pass, but it doesn't appear to work in my LXC Precise container. Please advise.

mitechie commented 10 years ago

This branch has exposed a bug in how the Bookie JS API is constructed. What's happening is that the two views are overwriting the callbacks on each other. We end up getting the api result for the user data, and that ends up getting fed into the bookmark success callback.

This bug is not with this branch, but due to the fact that there's a long standing bug this is exposing. I'm trying to chase it down, but it's in some deep JS magic code.

mitechie commented 10 years ago

This got some updates and is landed.

sambuddhabasu commented 10 years ago

@mitechie Will try looking into the bug. Thanks for the update.