search

bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 138 forks source link

All exceptions are now handled in database migration #458

Closed sambuddhabasu closed 10 years ago

sambuddhabasu commented 10 years ago

A different kind of exception was being raised, which caused the errors. Any kind of exceptions are now handled. Also, alembic version has been updated to 0.6.5

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080job/bookie-pgsql/60/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080job/bookie-base/71/

mitechie commented 10 years ago

Thanks for the pull request. I'd expect this to also have the version update in the requirements.txt file?

I've added a comment, this isn't quite ready to land yet, but I think you're on the right path updating the exception handling.

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080job/bookie-pgsql/62/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080job/bookie-base/72/

mitechie commented 10 years ago

Thanks for the update. The code looks good to me. :+1:

Once @pradyu1993 reviews it and checks it out this is ok to land via the shipit command.

preddy5 commented 10 years ago

+1

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/22/

mitechie commented 10 years ago

:shipit:

bookiebot commented 10 years ago

Status: merge request accepted. Url: http://ci.bookie.io:8080/job/bookie-lander