search

bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 138 forks source link

Database migration to support private bookmarks #461

Closed sambuddhabasu closed 10 years ago

sambuddhabasu commented 10 years ago

Exisitng bookmarks should be public

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/25/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/84/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/81/

mitechie commented 10 years ago

Have you tested the downgrade step?

I'd like to see one test added to the models test to verify the field is there and that the default is set properly.

I think this will be great with that test and verification that the downgrade works manually.

Thanks for the work. I'll add the +1 once the pull request is updated.

craigmaloney commented 10 years ago

Note: I tried this with sqlite3 and it appears that even after doing the upgrade .schema bmarks didn't show the column, even though the downgrade and subsequent upgrade steps told me it was still there. So sqlite3 may be more tricky than we realize.

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/28/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/89/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/83/

mitechie commented 10 years ago

Thanks! Looks good with the note on one more test that should probably be added. After that, it's good to land from me. :+1:

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/30/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/91/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/84/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/31/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/92/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/85/

preddy5 commented 10 years ago

:+1:

sambuddhabasu commented 10 years ago

:shipit:

bookiebot commented 10 years ago

Status: merge request accepted. Url: http://ci.bookie.io:8080/job/bookie-lander