Closed sambuddhabasu closed 10 years ago
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/33/
Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/94/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/86/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/34/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/95/
Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/87/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/35/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/96/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/88/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/38/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/99/
Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/90/
:+1:
This branch looks good. We should file a bug about the pgsql failures to investigate. It seems it started to get flaky after the migration to add is_private. Can you file that bug and add a card for that bug to trello we can look at soon?
Thanks for the change.
So, do you think that this branch is good to be merged? Also, I will file a bug shortly and also update the trello board.
Sorry yes to land. :+1: On May 29, 2014 7:04 PM, "Sambuddha Basu" notifications@github.com wrote:
So, do you think that this branch is good to be merged? Also, I will file a bug shortly and also update the trello board.
— Reply to this email directly or view it on GitHub https://github.com/bookieio/Bookie/pull/463#issuecomment-44596868.
:shipit:
Status: merge request accepted. Url: http://ci.bookie.io:8080/job/bookie-lander
Models tests have been updated to take into account the private flag with private and non-private count tests.