bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 138 forks source link

Private count tests added for models #463

Closed sambuddhabasu closed 10 years ago

sambuddhabasu commented 10 years ago

Models tests have been updated to take into account the private flag with private and non-private count tests.

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/33/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/94/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/86/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/34/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/95/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/87/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/35/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/96/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/88/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/38/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/99/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/90/

preddy5 commented 10 years ago

:+1:

mitechie commented 10 years ago

This branch looks good. We should file a bug about the pgsql failures to investigate. It seems it started to get flaky after the migration to add is_private. Can you file that bug and add a card for that bug to trello we can look at soon?

Thanks for the change.

sambuddhabasu commented 10 years ago

So, do you think that this branch is good to be merged? Also, I will file a bug shortly and also update the trello board.

mitechie commented 10 years ago

Sorry yes to land. :+1: On May 29, 2014 7:04 PM, "Sambuddha Basu" notifications@github.com wrote:

So, do you think that this branch is good to be merged? Also, I will file a bug shortly and also update the trello board.

— Reply to this email directly or view it on GitHub https://github.com/bookieio/Bookie/pull/463#issuecomment-44596868.

sambuddhabasu commented 10 years ago

:shipit:

bookiebot commented 10 years ago

Status: merge request accepted. Url: http://ci.bookie.io:8080/job/bookie-lander