Closed preddy5 closed 10 years ago
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/101/
Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/91/
I have reviewed it :+1:
Thanks for this update Prady, it's close but I think there's a few things to correct before landing. Let me know if you have any questions.
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/55/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/117/
Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/103/
This looks almost ready. As part of the mysql work I've noticed that we should be more specific when creating constraints (like the foreign key ones) and the Unicode() references should be Unicode(255).
After that and a round of QA I think this will be ready to move forward and land.
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/56/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/118/
Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/104/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/57/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/119/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/105/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/60/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/122/
Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/108/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/62/
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/124/
Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/110/
:+1: thanks for the updates
:shipit:
Status: merge request accepted. Url: http://ci.bookie.io:8080/job/bookie-lander
Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/40/