bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 138 forks source link

By default, bookmarks stored should be private #468

Closed sambuddhabasu closed 10 years ago

sambuddhabasu commented 10 years ago

By default, the store function of BmarkMgr should be storing private bookmarks unless specified otherwise.

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/43/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/106/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/94/

mitechie commented 10 years ago

This should have tests around store() and updating current code to specify the use. I know store is used in the import code specifically.

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/44/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/107/

mitechie commented 10 years ago

Thanks for adding the test. :+1: for this but I want to make sure we keep in mind that any imports that go on using this code will end up with all imported bookmarks as private.

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/95/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/45/

bookiebot commented 10 years ago

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/108/

bookiebot commented 10 years ago

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/96/

preddy5 commented 10 years ago

:+1:

sambuddhabasu commented 10 years ago

:shipit:

bookiebot commented 10 years ago

Status: merge request accepted. Url: http://ci.bookie.io:8080/job/bookie-lander