Tests added for api calls to support private bookmarks

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/54/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/116/

[bookiebot]

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/102/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/58/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/120/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/106/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/59/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/121/

[bookiebot]

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/107/

[mitechie]

This seems like a really good start Sam. I'm having some issues with the names of the test functions, but they're tough as they're complex.

I've got one suggest for making the access checks a bit easier. Let me know if that makes sense or not.

[sambuddhabasu]

Thanks Rick, I think the idea of having the has_access method looks good. It would make the code cleaner and more understandable.

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/61/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/123/

[bookiebot]

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/109/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/63/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/125/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/111/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/64/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/126/

[bookiebot]

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/112/

[mitechie]

:+1: and can land this after changing to not pass the whole User object into the has_access function. It's not a good idea to pass too much knowledge about domain models and such into simple functions such as well.

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/67/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/130/

[bookiebot]

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/114/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-mysql/68/

[bookiebot]

Test FAILed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-pgsql/131/

[bookiebot]

Test PASSed. Refer to this link for build results: http://ci.bookie.io:8080/job/bookie-base/115/

[preddy5]

:+1:

[mitechie]

:+1: thanks for the hard work on this branch. Hopefully these changes will make it nice and easy to move forward.

[sambuddhabasu]

:shipit: Yes, working on updating the api code completely.

[bookiebot]

Status: merge request accepted. Url: http://ci.bookie.io:8080/job/bookie-lander