search

bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 138 forks source link

search with private bookmarks fails to find correct set #507

Open mitechie opened 10 years ago

mitechie commented 10 years ago

When I search with a private bookmark and I do not check the box for 'check only my bookmarks' my private ones do not come out into the result set even though I'm searching and it's my private bookmark.

The flip side is that if I do check the 'only my bookmarks' then I get everyone's public bookmark matches still, however I do now get my private bookmark.

So it seems the query done when I check the checkbox for 'search only mine' should be the default setup and there's a bug in searching only my bookmarks for something that includes a private link.

mitechie commented 10 years ago

This is pretty crazy at the moment. The way the url structure is and the query params really falls into a crack of providing a url to specify a resource vs the api auth for who is requesting this data.

We need to rethink the api route and update all of the code along the path to search via the api.