search

bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 140 forks source link

Support hosting under a domain subpath (eg. example.org/bookie) #538

Closed anarcat closed 9 years ago

anarcat commented 9 years ago

This adds support for hosting Bookie on a subdomain. Some things still don't work quite right (ie. sometimes the slash after bookie in example.org.bookie is lost) but that's not frequent enough to be a blocker in my opinion.

We have been using this in production for months without much problem except the above now.

anarcat commented 9 years ago

any comments here?

craigmaloney commented 9 years ago

Apologies, we're a little busy over on this side. We'll take a peek at this shortly.

Thanks!

mitechie commented 9 years ago

This looks fine. I'd like to see what's up with the missing slash and try it for a bit before landing. A test setup would be good but might be a bit crazy to check everywhere a url is generated.

mitechie commented 9 years ago

Thanks for this PR. I'm landing this to get it into trunk and all tests pass. It'd be great if you could setup some docs on your install/setup for the subdirectory to help users take advantage of the functionality.

anarcat commented 9 years ago

where should that doc live? in https://github.com/bookieio/Bookie/blob/develop/docs/hosting.rst?

mitechie commented 9 years ago

I think that would be perfect.