bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 138 forks source link

bookie url click doesn't work if the url contains extended chars #551

Open alexlehm opened 9 years ago

alexlehm commented 9 years ago

I found a few urls I had in my import from delicious that contained an accented character in the url, e.g. amazon urls that contain the book title in the url. This doesn't happen when using an url copied from the browser url field since that is encoded, but I could reproduce it by manually entering an url.

When clicking on an url of that type in the bookie list, the redirect url gives a 404 error and editing the url does as well.

To reproduce this, click on add bookmark and enter this url http://www.amazon.de/Molwanien-schadhaften-Lächelns-Santo-Cilauro/dp/3453811380 , e.g. in my bookmark list, this gives the following link, which doesn't work https://bookie.io/alexlehm/redirect/a3aab825f7d7ef

Its possible to get to the link by copy'n'paste, but it would be better if the urls were converted or encoded to work correctly.

mitechie commented 9 years ago

Thanks for the report and sorry for the trouble. I though we had our utf8 in order. We'll peek at it.

alexlehm commented 9 years ago

of course it could be argued that this is not a valid url, since a browser will encode this as %C3%A4 automatically. when adding the url with the encoded chars, everything works

AnishShah commented 9 years ago

@mitechie working on this..