search

bookingcom / carbonapi

High-performance Graphite frontend in Go
Other
81 stars 23 forks source link

Consider to merge seriesByTag and aliasByTags to our repo #61

Open azhiltsov opened 5 years ago

azhiltsov commented 5 years ago

https://github.com/go-graphite/carbonapi/pull/384

Civil commented 5 years ago

You might also want to grab those changes alongside the original PR: https://github.com/go-graphite/carbonapi/commit/5f4972d48a31e392e8bad89dcdb496f472c4b379 https://github.com/go-graphite/carbonapi/commit/2406fe74ab136c58fe6ddd34f08787693a25bf6a

grzkv commented 5 years ago

@Civil Thanks. We will consider this. @gksinghjsr, could you have a look, please?

grzkv commented 5 years ago

https://github.com/go-graphite/carbonapi/commit/5f4972d48a31e392e8bad89dcdb496f472c4b379 is not mergeable. We have refactored these parts of the code. The other one may make sense to merge.

grzkv commented 5 years ago

To clarify, our general strategy is to only consider merging changes in the /expr folder.

Civil commented 5 years ago

My point was that after the PR was accepted, I've done some changes to it, which you may or may-not want to port. Completely up to you to decide which parts and how.