Add graceful SIGINT handling

bookingcom / carbonapi

High-performance Graphite frontend in Go

Other

81 stars 23 forks source link

Add graceful SIGINT handling #67

Closed grzkv closed 4 years ago

grzkv commented 5 years ago

Currently, we don't properly gracefully handle the termination signals.

The graceful shutdown should include

the flushes
stop receiving new requests
finish hanging requests

ksurent commented 4 years ago

I wanted to take a look at this but as I sat down to think what would need to be done, I realised that this is probably already solved.

both carbonapi and carbonzipper use Facebook's gracehttp which does graceful termination upon SIGTERM
SIGINT is not really something you get in production use
when developing, you probably want SIGINT to kill the thing ASAP (most of the time, anyway)

avereha commented 4 years ago

This issue is probably related to https://github.com/bookingcom/carbonapi/pull/229. It was also created before.

grzkv commented 4 years ago

This issue needs a re-evaluation. I think, @avereha is best equipped to do that now.

avereha commented 4 years ago

Going to close this issue. Let's reopen with specific bug report and reproduction steps if we find that we still have this issue(did not notice it in production).

grzkv commented 4 years ago

Totally agree. @avereha Thanks for reviewing.