search

bookingcom / nanotube

High-performance router for Graphite.
Apache License 2.0
56 stars 12 forks source link

Config parsing error log should contain a clue #17

Closed azhiltsov closed 4 years ago

azhiltsov commented 4 years ago

While dealing with #16 I found that it impossible to understand which line is causing the error ./nanotube -config config/config.toml -clusters config/clusters.toml -rules config/rules 2020/02/11 14:39:56 error reading main config: parsing error: toml: cannot load TOML value of type int64 into a Go float

Error should contain a clue what caused the error. Name of the parameter and line would be fine

grzkv commented 4 years ago

That's a good point. Thanks.

grzkv commented 4 years ago

Apparently, this requires changing the lib https://github.com/BurntSushi/toml/issues/217 :man_facepalming:

grzkv commented 4 years ago

We cannot fix this without changing the lib. I would rather not change the lib because the one currently in use seems to be working quite well and most used by the community.

So, I suggest we close this issue. @azhiltsov What do you think?

grzkv commented 4 years ago

Looking into this further, it turns out that in some cases you still get the location, but not in others.

I think it makes sense to close this for now.