bookingcom / powercalculator

Calculator to define runtime of experiments
https://bookingcom.github.io/powercalculator/
MIT License
87 stars 17 forks source link

Absolute per day on non inferiority test should affect threshold and sample #13

Closed Askoth closed 6 years ago

Askoth commented 6 years ago

Commented at https://github.com/bookingcom/powercalculator/commit/142f2a8c97335f2c22d7a0c32e202bec47772d94

There is the possibility of infinite loop if visitors per day changes sample

I commented the code that would cause the issue until I have a better solution that will provide the expected behavior