2.0.0 Adding Vuex store to power calculator and more tests: - Githubissues

bookingcom / powercalculator

Calculator to define runtime of experiments

https://bookingcom.github.io/powercalculator/

MIT License

87 stars 16 forks source link

2.0.0 Adding Vuex store to power calculator and more tests: #17

Closed Askoth closed 6 years ago

Askoth commented 6 years ago

better separation between UI and logic (Vuex): should will hopefully allow easier implementation of new features
eslint with rules focus on error prevention
jest is being used to text Vuex store. Focus is to be sure actions fired by user will update all pieces of the state needed.
update readme.md with the descrition of the test options

Bugfixes:

with the introduction of jest for vue files and eslint we found out some issues with the old code and they are fixed in this release:
- base rate wasn't updating properly when sample input fields were changed and we were calculating for impact
- switching between locked fields (runtime and visitors per day) was causing a very small variantion in sample when using non inferiority
- some issues with code with no detected impact to the user so far