bookingcom / powercalculator

Calculator to define runtime of experiments
https://bookingcom.github.io/powercalculator/
MIT License
87 stars 17 forks source link

Powercalculator 1.1.2v2 #8

Closed Askoth closed 6 years ago

Askoth commented 6 years ago

Had to create a new branch. Something was off with Powercalculator 1.1.2

Powercalculator will merge the default data with data sent by a parent component instead of replacing it. This means it will work with partial data, in case we want the power calculator to do the calculation instead of sharing a page with the result

Some tweaks to the graph:
- Rescale y-axis to make the x-axis less extreme
- increase visibility of alternative data points, for explicit comparisons
        E.g. but if I wait N more days, how much more power would my experiment
have ?
- Re-arrange order of graphs, assuming power is more static param than runtime
- Change default graph to be the first in the set

Bugfixes:
- fix js error when false rate is 0
- enforce updating other values of impact when url changes