bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm
Apache License 2.0
734 stars 39 forks source link

Export User-Agent for restclient #146

Open juliogreff opened 5 years ago

juliogreff commented 5 years ago

RESTLatencyMetric.Observe and RESTResultMetric.Increment in pkg/metrics/prometheus currently don't expose the User-Agent used to make requests. Without having it, it's difficult for us to see which controllers might be getting throttled, or just having issues in general, when talking to clusters.

Note that current client-go does not support this at all, so we'll probably have to get patches merged upstream first.

ksurent commented 5 years ago

Related: https://github.com/bookingcom/shipper/blob/35e77d70e4844f50883d4be2beeb11b9b7aa9057/cmd/shipper/main.go#L180.