search

bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm
Apache License 2.0
733 stars 39 forks source link

Upgraded to helm 2.15.0 fixes #102 #220

Closed osdrv closed 5 years ago

osdrv commented 5 years ago

This commit initialises our transition to the updated version of Helm (2.15+) which should solve our old issue with yaml converting digit-only docker image tags to scientific notation and breaks it all around.

The commit that fixes it was merged into helm v2 in version 2.15.0: https://github.com/helm/helm/commit/9014bd9c502d92fb78bfee553abdba5cf35e878f

The PR is going to stay in draft mode until helm 2.15 stable is released.

Signed-off-by: Oleg Sidorov oleg.sidorov@booking.com

osdrv commented 5 years ago

I'm closing this PR because we had to revert the changes in Helm: both dev-v2 and dev-v3. The change caused a major regression in numeric functions (see https://github.com/helm/helm/issues/6708 for more details). Our attempt to close the breach turned into an unreasonably massive and ugly change https://github.com/helm/helm/pull/6709, which didn't look like a small fix at all. Taking into consideration potential risks, the fixing PR has been closed with no merge and the initial change reverted. There is a possibility the problem would be fixed in the future versions of Helm3 (the idea is to use reflect-based function overloads; we've made some initial progress here: https://github.com/icanhazbroccoli/helm/commit/8b359af3c3e246e90c0e3f7667be494f19d8e716, but it's not close to anything working yet). My apologies for being over-optimistic and wasting so much time on it.