bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm
Apache License 2.0
733 stars 39 forks source link

scheduler: wrap mismatched owner references in a shipper error #255

Closed juliogreff closed 4 years ago

juliogreff commented 4 years ago

This prevents shipper from making assumptions on whether to retry errors cause by mismatched owner references for target objects:

Cannot determine if untagged error &errors.StatusError{...} is
retriable, will assume it is

This should be a non-retriable error, as it's an unrecoverable condition for shipper. This happens when a release is deleted and then re-created, and the correct course of action is for shipper to wait for kubernetes to garbage collect the old target objects, which will trigger a new sync of the Release, which can then create the new objects correctly.