bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm
Apache License 2.0
733 stars 39 forks source link

release controller: patch only strategy conditions #261

Closed juliogreff closed 4 years ago

juliogreff commented 4 years ago

This fixes a race condition where the release controller would update a Release's condition, then patch over it with the values removed, as they were just added after running the strategy executor.

Now, the strategy executor only patches .Status.Strategy for Releases, while the controller does a good ol' update to change .Status.AchievedStep and .Status.Conditions.