bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm
Apache License 2.0
734 stars 38 forks source link

installer: anchor installed objects to the installation target #309

Closed juliogreff closed 4 years ago

juliogreff commented 4 years ago

Before InstallationTargets were moved to the application clusters alongside the objects they were meant to install, we used an anchor ConfigMap object to be the parent of all the installed objects, to make garbage collection easier. That was because it was not possible to have their owner references point to the InstallationTarget itself, as it was in an entirely different cluster.

Now that InstallationTargets and installed objects live together, there is no longer a reason to have this anchor ConfigMap, as we can simply use the InstallationTarget itself as an anchor.

One caveat here is that existing Shipper users will still have their anchor config maps lying around. To ensure that they will also eventually be garbage collected when their parent InstallationTarget goes away, we need to update their OwnerReferences correctly as well.

Closes #278