bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm
Apache License 2.0
734 stars 38 forks source link

Fixes for release 0.9 #343

Closed hihilla closed 4 years ago

hihilla commented 4 years ago

Fix the migration code to not bail out on the first error. The migration code should collect errors on the way. This will help it deal with non-panic errors such as decommissioned cluster better. Making sure the migration code does not try and fail to update an initial target object for a dev cluster.

Fix wrong garbage collection. SearchStrings will return the index of the object in the array if found, or the index to insert this object of not found. It will return 0 if the item is located in index 0 in the array, and it will never return -1. As we would like to remove orphaned objects for Releases where they are not scheduled, we need a better way to check if this cluster is selected.