Shipperctl count command output option

bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm

Apache License 2.0

734 stars 38 forks source link

Shipperctl count command output option #347

Closed hihilla closed 3 years ago

hihilla commented 3 years ago

This pr adds to the new count command an output option. This allows the users of this command to also get a list of releases for future actions. For example shipperctl count contender --decommissionedClusters="decommissioned-a,decommissioned-b" -o json will output a json of the form [{"namespace": "yfouquet","name": "reserve-backend-test-359dc193-0"},{"namespace": "yfouquet", "name": "reserve-backend-test-359dc193-0" },...] which allows the user to handle these cases separately.

nodo commented 3 years ago

LGTM 👍

nodo commented 3 years ago

OT comment:

Do these commands make sense for non-decommissioned clusters? If this is the case we could change the flag to --clusters. WDYT?

shipperctl count contender --clusters="..."