bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm
Apache License 2.0
733 stars 39 forks source link

Run Shipper webhook on app clusters, too #350

Closed parhamdoustdar closed 3 years ago

parhamdoustdar commented 4 years ago

Currently, the webhook only exists in the management cluster, which means that some of the sanity checks we have in the webhook (e.g. making sure that the object deserializes correctly) are not running in application clusters. This means that a wrong YAML object, for example, could break Shipper in the relevant application cluster.

kanatohodets commented 4 years ago

This seems like it can be closed, given that we're not moving ahead right now with the app cluster Shipper agent.