bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm
Apache License 2.0
733 stars 39 forks source link

Update shipperctl count and clean commands #353

Closed hihilla closed 4 years ago

hihilla commented 4 years ago

Deleting history releases is not a smart move. Instead, we should delete the annotations and let Shipper reschedule these releases. Emptying the scheduled clusters annotation will make Shipper re-schedule this release. If this release is a history release, Shipper will enforce strategy correctly (no capacity and no traffic). However, if this release is contender, Shipper will possibly give capacity and traffic to a release that did not have a running workload. This might cause an unmonitored, unexpected, and unwanted behavior from this release. So we are not touching contenders. This applies to incumbents in an incomplete rollout.