bookingcom / shipper

Kubernetes native multi-cluster canary or blue-green rollouts using Helm
Apache License 2.0
734 stars 38 forks source link

Fixed targetStep in the example release.yaml #361

Closed hihilla closed 3 years ago

hihilla commented 3 years ago

This is a cherry-pick for #311

The example release object used in the high-level API overview defines spec.targetStep as 0 and status.achievedState as 2, whereas status.strategy.state declares all 4 state attributes (installation, traffic, capacity and command) as False, which indicates that the release is complete. This might be misleading for a reader as this release state is unstable and immediately provokes a chain of changes by Shipper. Declaring targetStep as 2 makes more sense as this brings the release to a "happy" complete state and the rest of the conditions and state attributes make sense.

Signed-off-by: Oleg Sidorov oleg.sidorov@booking.com