booksaw / BetterTeams

Create teams to fight to be the best (Minecraft Plugin)
https://www.spigotmc.org/resources/better-teams.17129/
MIT License
63 stars 43 forks source link

[BUG] All placeholders need a non-null sender even if it its not used #473

Closed Aeliios closed 1 year ago

Aeliios commented 1 year ago

What is the bug?

Placeholders such as %betterTeams_position_etc% need a online sender, which is not required.

Expected Behaviour

Return good value, even with a null sender.

How to Reproduce

/papi parse --null %betterTeams_position_name_1% -> returns "" instead of team's name.

Error message

No response

Output of /teama version

[BetterTeams] Storage Method: com.booksaw.betterTeams.team.storage.storageManager.SeparatedYamlStorageManager [BetterTeams] Minecraft Version: git-Paper-55 (MC: 1.20.1) [BetterTeams] Language Selected: messages [BetterTeams] Current plugin version: 4.6.7

Additional Information

No response

booksaw commented 1 year ago

This feature has been implemented and will be included in the next update. Thank you for the suggestion.