search

booksaw / BetterTeams

Create teams to fight to be the best (Minecraft Plugin)
https://www.spigotmc.org/resources/better-teams.17129/
MIT License
63 stars 43 forks source link

Improve placeholder system #477

Closed booksaw closed 1 year ago

booksaw commented 1 year ago

Aims to standardize the placeholder process, by using the same placeholder system for both player based placeholders (such as %betterteams_name%) along with ranked placeholders (such as &betterteams_position_1_name%). This PR ensures all types of placeholder, such as relational, ranked etc. have the exact same suffixes (such as name, money etc.)

Some previous placeholders will need to be re-made with the new syntax.

Invalidates the following PRs due to implementing their changes in the reworked system: #474 #470. These contributions are still greatly appreciated as they were the starting point of this rewrite.

Due to including the requested features in the following feature requests, this PR closes: #463 #451 #473 #442 #438 #389 #343 #399

booksaw commented 1 year ago

@SavageAvocado @Aeliios As you have worked with this plugins placeholders code, I would appreciate any feedback on this PR.

SavageAvocado commented 1 year ago

Looks great! There's just one small thing I noticed, It looks like you missed a System.out.println in the DescriptionPlaceholderProvider.

Aeliios commented 1 year ago

Hey, I've made multiple suggestions on your code (wrong array input & npe fix), otherwise it looks great.

booksaw commented 1 year ago

Hey, I've made multiple suggestions on your code (wrong array input & npe fix), otherwise it looks great.

Hey, I cant find your proposed changes, please could you let me know where to find them