booksaw / BetterTeams

Create teams to fight to be the best (Minecraft Plugin)
https://www.spigotmc.org/resources/better-teams.17129/
MIT License
71 stars 46 forks source link

[BUG] Fatal Server Frezze when unloading the Plugin #486

Closed Dev0Louis closed 1 year ago

Dev0Louis commented 1 year ago

What is the bug?

When the Plugin is being disabled the Server gets stuck, worst of all even the Server Monitor that should kill the Server in such an scenario does not kill it. And the Plugin is disabled before player and world data gets saved! So Players will be rolled back 1-5 minutes with items being duplicated or deleted.

Expected Behaviour

It should not happen.

How to Reproduce

  1. Start the Server
  2. Stop the Server

Error message

17:52:55 ERROR: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH - git-Paper-84 (MC: 1.20.1) --- 17:52:55 ERROR: The server has not responded for 40 seconds! Creating thread dump

17:52:55 ERROR: Server thread dump (Look for plugins here before reporting to Paper!):

17:52:55 ERROR: Current Thread: Server thread 17:52:55 ERROR: PID: 43 | Suspended: false | Native: false | State: RUNNABLE

17:52:55 ERROR: java.base@20.0.1/java.util.concurrent.CopyOnWriteArrayList.remove(Unknown Source) 17:52:55 ERROR: java.base@20.0.1/java.util.concurrent.CopyOnWriteArrayList.remove(Unknown Source)

17:52:55 ERROR: PluginManager.jar//net.lenni0451.spm.utils.PluginUtils$$Lambda$11561/0x0000000802472318.accept(Unknown Source) 17:52:55 ERROR: java.base@20.0.1/java.util.Optional.ifPresent(Unknown Source)

17:52:55 ERROR: PluginManager.jar//net.lenni0451.spm.commands.PluginManager_Command$$Lambda$11288/0x0000000802470fa8.run(Unknown Source)

17:52:55 ERROR: net.minecraft.server.MinecraftServer$$Lambda$4743/0x000000080164f1d8.run(Unknown Source) 17:52:55 ERROR: java.base@20.0.1/java.lang.Thread.runWith(Unknown Source) 17:52:55 ERROR: java.base@20.0.1/java.lang.Thread.run(Unknown Source)

17:52:55 ERROR: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH ---

Output of /teama version

[18:08:07 INFO]: [Soul] Storage Method: com.booksaw.betterTeams.team.storage.storageManager.SQLStorageManager [18:08:07 INFO]: [Soul] Minecraft Version: git-Paper-84 (MC: 1.20.1) [18:08:07 INFO]: [Soul] Language Selected: de [18:08:07 INFO]: [Soul] Aktuelle Plugin-Version: 4.7.1

Additional Information

No response

Dev0Louis commented 1 year ago

The Issue vanished with #488

booksaw commented 1 year ago

Closing as PR has solved issue.