booksaw / BetterTeams

Create teams to fight to be the best (Minecraft Plugin)
https://www.spigotmc.org/resources/better-teams.17129/
MIT License
63 stars 43 forks source link

[BUG] Placeholder Thread Creation #576

Closed R00tB33rMan closed 2 months ago

R00tB33rMan commented 3 months ago

What is the bug?

Plugins such as FancyHolograms permit unlimited thread creation. Although FancyHolograms should monitor/limit this, BetterTeams should, too, because BetterTeams appears to create threads infinitely.

The author of FancyHolograms claims it's not something he can necessarily resolve, so I instead come to you to resolve this issue.

Expected Behaviour

Thread limit is capped or managed more efficiently.

How to Reproduce

  1. Install FancyHolograms + BetterTeams
  2. Create a leaderboard with FancyHolograms containing the BetterTeams placeholder(s)
  3. Have a lot of users within that area and watch as the server massively depreciated in stability

Error message

None

Output of /teama version

Storage Method: com.booksaw.betterTeams.team.storage.storageManager.SeparatedYamlStorageManager Minecraft Version: git-UniverseSpigot-"7b6182b" (MC: 1.20.4) Language Selected: messages Online mode: false (Is online mode; running behind proxy) Player count: 143 Current plugin version: 4.9.0

Additional Information

spark report: https://spark.lucko.me/8QYQl7BzJm

booksaw commented 2 months ago

Duplicate of #482