booksaw / BetterTeams

Create teams to fight to be the best (Minecraft Plugin)
https://www.spigotmc.org/resources/better-teams.17129/
MIT License
72 stars 46 forks source link

About The Message System of BetterTeams plugin [BUG] #626

Open IamsadVN opened 4 months ago

IamsadVN commented 4 months ago

What is the bug?

I have noticed some issues related to the Message system. It seems that when I just installed the Plugin on my server, the message.yml file wasn't created properly. I'm not sure if that's the right way to say it, but the file should have loaded all the messages from GitHub or something. However, it didn't load completely and some messages were missing. These missing messages caused the server console to continuously display missing message notifications. And I noticed that the missing messages are usually in the help section. It's only when a user uses the /team help command that the missing messages load and appear in message.yml.

Expected Behaviour

I hope BetterTeams should check again the message code

How to Reproduce

And I am also the translator for this Plugin, which is how I discovered the issue. In fact, when I translated this plugin, I copied the message.yml file and then edited the content of each message. After finishing the translation, I tried using my translated file. But it reported missing messages in the server console, so I tried deleting the message.yml file and then let the plugin automatically download the message file again. However, now the console says that the message.yml file is missing some messages. I found it very confusing. Then, I tried using the team help and teama help commands to check if the plugin was missing those messages and if it would report errors. After using those commands, I went back to VS Code to check the file and saw that there were new messages at the bottom of the file (specifically at the end of the help section).

Error message

[17:53:10 INFO]: [BetterTeams] Enabling BetterTeams v4.9.4 [17:53:10 INFO]: [BetterTeams] Checking if the file vi.yml is up to date [17:53:10 INFO]: [BetterTeams] ================================================================== [17:53:10 INFO]: [BetterTeams] File is not updated, adding values under the following references: [17:53:10 INFO]: [BetterTeams] - help.warps [17:53:10 INFO]: [BetterTeams] - help.rankup [17:53:10 INFO]: [BetterTeams] - help.tag [17:53:10 INFO]: [BetterTeams] - help.delwarp [17:53:10 INFO]: [BetterTeams] - help.chest [17:53:10 INFO]: [BetterTeams] - help.pvp [17:53:10 INFO]: [BetterTeams] - help.baltop [17:53:10 INFO]: [BetterTeams] - help.list [17:53:10 INFO]: [BetterTeams] - help.warp [17:53:10 INFO]: [BetterTeams] - help.removeall [17:53:10 INFO]: [BetterTeams] - help.claim [17:53:10 INFO]: [BetterTeams] - help.remove [17:53:10 INFO]: [BetterTeams] vi.yml is now updated to the latest version, thank you for using BetterTeams [17:53:10 INFO]: [BetterTeams] ================================================================== [17:53:10 INFO]: [BetterTeams] Checking if the file messages.yml is up to date [17:53:10 INFO]: [BetterTeams] File is up to date

image

Output of /teama version

image

Additional Information

No response

booksaw commented 3 months ago

I notice the log mentions you are using vi.yaml translations but your /teama version output does not mention it?

booksaw commented 3 months ago

Also some improvements in the translation space are coming in the next update

IamsadVN commented 3 months ago

I notice the log mentions you are using vi.yaml translations but your /teama version output does not mention it?

you mean the translation of /teama version output? I think at that time I changed the language to English so /teama version will appear in English, or because the vi.yaml file is missing the /teama version part so it will use English to replace the "key" part that is missing translation

stale[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.