search

booksaw / BetterTeams

Create teams to fight to be the best (Minecraft Plugin)
https://www.spigotmc.org/resources/better-teams.17129/
MIT License
71 stars 45 forks source link

Code cleanup #637

Open svaningelgem opened 4 months ago

svaningelgem commented 4 months ago

Thanks a lot @booksaw for your fixes!

I added a (lot more) issues my IDE noticed. Each commit is 1 particular issue. Mostly harmless.

Everything compiles fine 😀

booksaw commented 3 months ago

By the way, thanks for separating changes into different commits, it makes it a lot easier to review :)

svaningelgem commented 3 months ago

Just as a word of warning, I am very hesitant to PRs that have these many minor changes. I completely understand. Problem is once I started with the code validation in my IDE, I just kept adding stuff. Luckily the commit-by-commit approach seems to improve that a bit for you.

Normally in this PR there are no real changes. Just cleanup of your excellent codebase based on IntelliJ's comments about it.

svaningelgem commented 2 months ago

Hi @booksaw , any chance you got lately to continue your review of this PR?

Thanks!