search

booksaw / BetterTeams

Create teams to fight to be the best (Minecraft Plugin)
https://www.spigotmc.org/resources/better-teams.17129/
MIT License
71 stars 45 forks source link

[BUG] TeamDisallowedPvPEvent: removed? #638

Closed svaningelgem closed 3 months ago

svaningelgem commented 4 months ago

What is the bug?

I noticed that there was code with TeamDisallowedPvPEvent in canDamage. But in one of the latest commits this has been removed (unintentional merge?)

Expected Behaviour

either remove the class (and the readme doc), or bring it back?

How to Reproduce

See code around here: https://github.com/booksaw/BetterTeams/blob/master/src/main/java/com/booksaw/betterTeams/Team.java#L1308

Error message

No response

Output of /teama version

not applicable

Additional Information

No response

booksaw commented 3 months ago

Fixed by a PR by @Hellinduction

svaningelgem commented 3 months ago

@booksaw : I don't know if you know, but am going to put it out here anyhow 😀: If you mention in the PR "Closes #638", and the PR gets merged, Github will automagically close the mentioned issues for you, and even add a link to it in the audit log of the issue.