booksaw / BetterTeams

Create teams to fight to be the best (Minecraft Plugin)
https://www.spigotmc.org/resources/better-teams.17129/
MIT License
71 stars 45 forks source link

[BUG] SQL Update echest #644

Closed bobhenl closed 2 months ago

bobhenl commented 3 months ago

What is the bug?

Hello, I got this error in console, prob when player tried to put item into the echest, btw I think I have echests disabled.

Expected Behaviour

No error

How to Reproduce

Try to put item into echests

Error message

0:35:34] [Server thread/INFO]: Extremo97 issued server command: /team echest [10:35:34] [Server thread/INFO]: [NPCReplay] Loading actions from: recording_4.json [10:35:35] [Server thread/ERROR]: Something went wrong while executing SQL [10:35:35] [Server thread/ERROR]: SQL: UPDATE BetterTeams_Team SET echest = "items: '0': ==: org.bukkit.inventory.ItemStack v: 3953 type: DIAMOND_SWORD meta: ==: ItemMeta meta-type: UNSPECIFIC display-name: '{\"text\":\"\",\"extra\":[{\"text\":\"> \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"gray\",\"bold\":false},{\"text\":\"P\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#9E00FF\",\"bold\":true},{\"text\":\"v\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#9321FF\",\"bold\":true},{\"text\":\"P \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#8843FF\",\"bold\":true},{\"text\":\"S\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#7D64FF\",\"bold\":true},{\"text\":\"w\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#7286FF\",\"bold\":true},{\"text\":\"o\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#67A7FF\",\"bold\":true},{\"text\":\"r\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#5CC9FF\",\"bold\":true},{\"text\":\"d \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#51EAFF\",\"bold\":true},{\"text\":\"<\",\"italic\":false,\"color\":\"gray\",\"bold\":false}]}' lore:

Output of /teama version

[12:05:11 INFO]: Storage Method: com.booksaw.betterTeams.team.storage.storageManager.SQLStorageManager [12:05:11 INFO]: Minecraft Version: 1.21-2275-82ccc76 (MC: 1.21) [12:05:11 INFO]: Language Selected: messages [12:05:11 INFO]: Online mode: false [12:05:11 INFO]: Player count: 46 [12:05:11 INFO]: Current plugin version: 4.9.4

Additional Information

Doesn't I have it disabled? maxChests: 0 (in all levels)

But I haven't disabled perms on this: echest: enabled: true rank: DEFAULT chest: enabled: true

booksaw commented 3 months ago

maxChests is for phsyical chest claims (stand on the chest and run /team chest claim then other teams cannot open it) rather than echests, so the functionality is not currently disabled.

Are there any further logs below the line you have provided? There should be another ~20 lines of error message which will be helpful in identifying the problem.

bobhenl commented 3 months ago

Here are the logs. Also, how to block the ender chest please?

EDIT: OK I REPRODUCED IT, HERE'S THE FULL ERROR:

20:44:52 INFO]: Renzotom issued server command: /team echest
[20:44:55 ERROR]: Something went wrong while executing SQL
java.sql.SQLException: No value specified for parameter 1
        at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:121)
        at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:113)
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1135)
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1045)
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeLargeUpdate(ClientPreparedStatement.java:1369)
        at com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdate(ClientPreparedStatement.java:1030)
        at BetterTeams-4.9.4.jar//com.booksaw.betterTeams.database.api.Database.executeStatement(Database.java:172)
        at BetterTeams-4.9.4.jar//com.booksaw.betterTeams.team.storage.team.SQLTeamStorage.setEchestContents(SQLTeamStorage.java:179)
        at BetterTeams-4.9.4.jar//com.booksaw.betterTeams.team.EChestComponent.save(EChestComponent.java:34)
        at BetterTeams-4.9.4.jar//com.booksaw.betterTeams.Team.saveEchest(Team.java:1442)
        at BetterTeams-4.9.4.jar//com.booksaw.betterTeams.events.InventoryManagement.onClose(InventoryManagement.java:36)
[20:44:55 ERROR]: SQL: UPDATE BetterTeams_Team SET echest = "items:
  '21':
    ==: org.bukkit.inventory.ItemStack
    v: 3953
    type: DIAMOND_SWORD
    meta:
      ==: ItemMeta
      meta-type: UNSPECIFIC
      display-name: '{\"text\":\"\",\"extra\":[{\"text\":\"> \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"gray\",\"bold\":false},{\"text\":\"P\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#9E00FF\",\"bold\":true},{\"text\":\"v\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#9321FF\",\"bold\":true},{\"text\":\"P
        \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#8843FF\",\"bold\":true},{\"text\":\"S\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#7D64FF\",\"bold\":true},{\"text\":\"w\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#7286FF\",\"bold\":true},{\"text\":\"o\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#67A7FF\",\"bold\":true},{\"text\":\"r\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#5CC9FF\",\"bold\":true},{\"text\":\"d
        \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"#51EAFF\",\"bold\":true},{\"text\":\"<\",\"italic\":false,\"color\":\"gray\",\"bold\":false}]}'
      lore:
      - '{\"text\":\"\",\"extra\":[{\"text\":\"| HOW IT WORKSteamID LIKE '4fd1438d-946a-457c-b4e7-e131be454976'\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"blue\",\"bold\":true}]}'
      - '{\"text\":\"\",\"extra\":[{\"text\":\"|\",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"blue\",\"bold\":true}]}'
      - '{\"text\":\"\",\"extra\":[{\"text\":\"| \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"blue\",\"bold\":true},{\"text\":\"Equipping
        this sword engages \",\"italic\":false,\"color\":\"white\",\"bold\":false},{\"text\":\"PvP
        \",\"italic\":false,\"color\":\"blue\"},{\"text\":\"and \",\"italic\":false,\"color\":\"white\"},{\"text\":\"armor\",\"italic\":false,\"color\":\"blue\"},{\"text\":\".\",\"italic\":false,\"color\":\"white\"}]}'
      - '{\"text\":\"\",\"extra\":[{\"text\":\"| \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"blue\",\"bold\":true},{\"text\":\"Safe
        in spawn\",\"italic\":false,\"color\":\"green\",\"bold\":false},{\"text\":\": lose hearts,
        not stuff.\",\"italic\":false,\"color\":\"white\"}]}'
      - '{\"text\":\"\",\"extra\":[{\"text\":\"| \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"blue\",\"bold\":true},{\"text\":\"Risky
        in warzone/wild\",\"italic\":false,\"color\":\"red\",\"bold\":false},{\"text\":\": lose
        everything,\",\"italic\":false,\"color\":\"white\"}]}'
      - '{\"text\":\"\",\"extra\":[{\"text\":\"| \",\"obfuscated\":false,\"italic\":false,\"underlined\":false,\"strikethrough\":false,\"color\":\"blue\",\"bold\":true},{\"text\":\"including
        sword. Be careful.\",\"italic\":false,\"color\":\"white\",\"bold\":false}]}'
      custom-model-data: 484985
      enchants:
        minecraft:sharpness: 1
      Damage: 165
" WHERE ?
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor834.execute(Unknown Source)
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77)
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54)
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628)
        at org.bukkit.craftbukkit.event.CraftEventFactory.handleInventoryCloseEvent(CraftEventFactory.java:1641)
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClose(ServerGamePacketListenerImpl.java:2956)
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClose(ServerGamePacketListenerImpl.java:2949)
        at net.minecraft.network.protocol.game.ServerboundContainerClosePacket.handle(ServerboundContainerClosePacket.java:33)
        at net.minecraft.network.protocol.game.ServerboundContainerClosePacket.handle(ServerboundContainerClosePacket.java:15)
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:56)
        at net.minecraft.server.TickTask.run(TickTask.java:18)
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151)
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24)
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1573)
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:201)
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125)
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1550)
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1543)
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:135)
        at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1502)
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1509)
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1354)
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:333)
        at java.base/java.lang.Thread.run(Thread.java:1583)

And here are the data about the item:

[20:45:51 INFO]: --------------------------------------------------
[20:45:51 INFO]: id (String): minecraft:diamond_sword
[20:45:51 INFO]: count (Int): 1
[20:45:51 INFO]: components (Compound)
[20:45:51 INFO]:   minecraft:lore (List)
[20:45:51 INFO]:     - {"extra":[{"bold":true,"color":"blue","italic":false,"obfuscated":false,"strikethrough":false,"text":"| HOW IT WORKS?","underlined":false}],"text":""}
[20:45:51 INFO]:     - {"extra":[{"bold":true,"color":"blue","italic":false,"obfuscated":false,"strikethrough":false,"text":"|","underlined":false}],"text":""}
[20:45:51 INFO]:     - {"extra":[{"bold":true,"color":"blue","italic":false,"obfuscated":false,"strikethrough":false,"text":"| ","underlined":false},{"bold":false,"color":"white","italic":false,"text":"Equipping this sword engages "},{"color":"blue","italic":false,"text":"PvP "},{"color":"white","italic":false,"text":"and "},{"color":"blue","italic":false,"text":"armor"},{"color":"white","italic":false,"text":"."}],"text":""}
[20:45:51 INFO]:     - {"extra":[{"bold":true,"color":"blue","italic":false,"obfuscated":false,"strikethrough":false,"text":"| ","underlined":false},{"bold":false,"color":"green","italic":false,"text":"Safe in spawn"},{"color":"white","italic":false,"text":": lose hearts, not stuff."}],"text":""}
[20:45:51 INFO]:     - {"extra":[{"bold":true,"color":"blue","italic":false,"obfuscated":false,"strikethrough":false,"text":"| ","underlined":false},{"bold":false,"color":"red","italic":false,"text":"Risky in warzone/wild"},{"color":"white","italic":false,"text":": lose everything,"}],"text":""}
[20:45:51 INFO]:     - {"extra":[{"bold":true,"color":"blue","italic":false,"obfuscated":false,"strikethrough":false,"text":"| ","underlined":false},{"bold":false,"color":"white","italic":false,"text":"including sword. Be careful."}],"text":""}
[20:45:51 INFO]:   minecraft:enchantments (Compound)
[20:45:51 INFO]:     levels (Compound)
[20:45:51 INFO]:       minecraft:sharpness (Int): 1
[20:45:51 INFO]:   minecraft:custom_name (String): {"extra":[{"bold":false,"color":"gray","italic":false,"obfuscated":false,"strikethrough":false,"text":"> ","underlined":false},{"bold":true,"color":"#9E00FF","italic":false,"obfuscated":false,"strikethrough":false,"text":"P","underlined":false},{"bold":true,"color":"#9321FF","italic":false,"obfuscated":false,"strikethrough":false,"text":"v","underlined":false},{"bold":true,"color":"#8843FF","italic":false,"obfuscated":false,"strikethrough":false,"text":"P ","underlined":false},{"bold":true,"color":"#7D64FF","italic":false,"obfuscated":false,"strikethrough":false,"text":"S","underlined":false},{"bold":true,"color":"#7286FF","italic":false,"obfuscated":false,"strikethrough":false,"text":"w","underlined":false},{"bold":true,"color":"#67A7FF","italic":false,"obfuscated":false,"strikethrough":false,"text":"o","underlined":false},{"bold":true,"color":"#5CC9FF","italic":false,"obfuscated":false,"strikethrough":false,"text":"r","underlined":false},{"bold":true,"color":"#51EAFF","italic":false,"obfuscated":false,"strikethrough":false,"text":"d ","underlined":false},{"bold":false,"color":"gray","italic":false,"text":"<"}],"text":""}
[20:45:51 INFO]:   minecraft:custom_model_data (Int): 484985
[20:45:51 INFO]:   minecraft:damage (Int): 165
[20:45:51 INFO]: --------------------------------------------------
stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.